On Tue, Mar 12, 2019 at 03:59:15PM +0000, Kieran Bingham wrote: > Hi Ville, > > On 12/03/2019 15:14, Ville Syrjälä wrote: > > On Tue, Mar 12, 2019 at 12:33:07AM +0000, Kieran Bingham wrote: > >> Trivial fixes identified while working on the DRM code. > >> > >> s/artifically/artificially/ > >> s/achive/achieve/ > >> > >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > >> --- > >> > >> v2: - Actually spell achieve correctly! > > > > drm convention is to put this above the --- so that it gets included in > > the commit msg. > > Oh - in linux-media these are just dropped. > > I'll try to remember this for my future work in DRM. > > I don't have commit access anyway, so can I presume whomever will pick > this up will adjust if necessary? Ah. Yeah, it's fine. Now pushed with the adjustement. Thanks for the patch. > > Or should I repost? (which might be a bit redundant just to move a patch > version comment which would then increase again :D ) > > > > With that > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Thanks, > -- > Regards > > Kieran > > > > > >> > >> drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > >> index 540a77a2ade9..2453678d1186 100644 > >> --- a/drivers/gpu/drm/drm_atomic_helper.c > >> +++ b/drivers/gpu/drm/drm_atomic_helper.c > >> @@ -1752,7 +1752,7 @@ int drm_atomic_helper_commit(struct drm_device *dev, > >> * > >> * NOTE: Commit work has multiple phases, first hardware commit, then > >> * cleanup. We want them to overlap, hence need system_unbound_wq to > >> - * make sure work items don't artifically stall on each another. > >> + * make sure work items don't artificially stall on each another. > >> */ > >> > >> drm_atomic_state_get(state); > >> @@ -1786,7 +1786,7 @@ EXPORT_SYMBOL(drm_atomic_helper_commit); > >> * > >> * Asynchronous workers need to have sufficient parallelism to be able to run > >> * different atomic commits on different CRTCs in parallel. The simplest way to > >> - * achive this is by running them on the &system_unbound_wq work queue. Note > >> + * achieve this is by running them on the &system_unbound_wq work queue. Note > >> * that drivers are not required to split up atomic commits and run an > >> * individual commit in parallel - userspace is supposed to do that if it cares. > >> * But it might be beneficial to do that for modesets, since those necessarily > >> -- > >> 2.19.1 > > -- Ville Syrjälä Intel
