Hello! On 03/11/2019 10:49 AM, Kangjie Lu wrote: > of_get_phy_mode may fail and return a negative error code; > the fix checks the return value of of_get_phy_mode and > returns NULL of it fails. Sorry, I overlooked this issue. > Signed-off-by: Kangjie Lu <kjlu@xxxxxxx> Fixes: b356e978e92f ("sh_eth: add device tree support") Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > --- > drivers/net/ethernet/renesas/sh_eth.c | 2 ++ > 1 file changed, 2 insertions(+) Why are you not fixing ravb_main.c as well? Especially as you have "renesas:" in your subject, not "sh_eth:"? :-/ [...] MBR, Sergei