On Sat, Mar 2, 2019 at 3:49 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > So, finally, here is the second RFC for supporting I2C transfers in atomic > contexts (i.e. very late). This will need some text because I tried some things > on the way but had to discard them. However, I think it is important to have > that documented. > Sorry, no TLDR; text here - I think this topic deserves a few words ;) Thank you for this work! It was indeed interesting reading. And since your series is targetting some exiting use cases, I would drop as well academic variants of brain-damaged hw design, I think it worth to go. WRT patches, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> for patches 1-2 and FWIW for patches 3-4. For the individual drivers I can't say much, code looks good, but I dunno if it's correct or not. > > Looking forward to comments, thanks! > > Wolfram > > > [1] http://patchwork.ozlabs.org/patch/1044789/ > > > Tero Kristo (1): > i2c: busses: omap: Add the master_xfer_irqless hook > > Wolfram Sang (6): > i2c: apply coding style for struct i2c_adapter > i2c: core: use I2C locking behaviour also for SMBUS > i2c: core: introduce callbacks for atomic transfers > i2c: demux: WIP: handle the new atomic callbacks > i2c: tegra-bpmp: convert to use new atomic callbacks > i2c: algo: bit: HACK! add atomic callback > > drivers/i2c/algos/i2c-algo-bit.c | 5 ++- > drivers/i2c/busses/i2c-omap.c | 79 +++++++++++++++++++++++++++++------ > drivers/i2c/busses/i2c-tegra-bpmp.c | 27 +++++++++--- > drivers/i2c/i2c-core-base.c | 17 ++++---- > drivers/i2c/i2c-core-smbus.c | 25 ++++++++--- > drivers/i2c/i2c-core.h | 15 +++++++ > drivers/i2c/muxes/i2c-demux-pinctrl.c | 3 ++ > include/linux/i2c.h | 38 +++++++++++------ > 8 files changed, 162 insertions(+), 47 deletions(-) > > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko
