Re: [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 26, 2019 at 09:28:53AM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> Thank you for your patch
> 
> > Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> > recommendation that #address-cells / #size-cells is only needed.
> > 
> > This addresses the following warning:
> > 
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > 
> > This change should not have any run-time effect.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > 
> > ---
> > Build tested against renesas-devel-20190214-v5.0-rc6
> > ---
> >  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > index a225c2457274..20b35991bc17 100644
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > @@ -716,6 +716,15 @@
> >  				capture  = <&ssi1 &src1 &dvc1>;
> >  			};
> >  		};
> > +
> > +		/* Dummy node to be overriden by board DT
> > +		 * Satisfies dtc recommendation that
> > +		 * #address-cells / #size-cells is only needed
> > +		 * for graph nodes with multiple child nodes.
> > +		 */
> > +		rsnd_port1: port@1 {
> > +			reg = <1>;
> > +		};
> >  	};
> >  };
> 
> This solution is strange for me.
> I want to solve it, but I couldn't reproduce this.
> Which branch, and how to reproduce it ?

Thanks Morimoto-san,

I see this on renesas-devel-20190225-v5.0-rc8 using:

ARCH=arm64 make dtbs W=1



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux