Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

On Fri, Feb 22, 2019 at 12:30 PM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> On Fri, Feb 22, 2019 at 12:17:47PM +0100, Jacopo Mondi wrote:
> > On Fri, Feb 22, 2019 at 01:04:29PM +0200, Sakari Ailus wrote:
> > > You can btw. zero the struct memory by assigning { 0 } to it in
> > > declaration. memset() in general is much more trouble. In this case you
> > > could even do the assignments in delaration as well.
> > >
> >
> > Thanks, noted. I have been lazy and copied memset from other places in
> > the ioctl handling code. I should check on your suggestions because I
> > remember one of the many 0-initialization statement was a GCC specific one,
> > don't remember which...
>
> {} is GCC specific whereas { 0 } is not. But there have been long-standing
> GCC bugs related to the use of { 0 } which is quite unfortunate --- they've
> produced warnings or errors from code that is valid C...

Most of these are gone since commit cafa0010cd51fb71 ("Raise the minimum
required gcc version to 4.6").

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux