> >>> + ret = gpiod_direction_output(priv->scl, 1); > >> > >> This may overwrite the error code returned by request_irq(). > > > > Yeah. What do you think about this, is this too dense? > > > > ret = gpiod_direction_output(priv->scl, 1) ?: ret; > > That may also overwrite the error code, of course. Isn't it > usually best to return the first error? I have no clue if that > guideline does not apply here, though... I am neither entirely sure here. My take was that the above was the more severe error. Because if setting to output fails, the GPIO I2C bus will be broken. If the former stuff fails, well, the injection didn't work or was interrupted. However, the GPIO was set to output before the injector. So, if setting it back fails, then the system likely has more severe problems anyhow? I am open to any better solution. However, let's not forget, this is debug code aimed to be used by devs.
Attachment:
signature.asc
Description: PGP signature
