Hi Laurent,
On 17/02/2019 12:00, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:45PM +0000, Kieran Bingham wrote:
>> Provide the pass-through option of --queue-late to vsp-runner, to request
>> that yavta will queue frames after the stream has started.
>
> As with 5/7, what is the use case for this ?
I'm sure it had a very good use case at the time.
Please ask 2 months ago Kieran ... Current Kieran has no idea :)
And then let me borrow your time machine - I have some good uses for it :D
I remember asking you about this option in fact, but I can't remember
what I was testing specifically, or why I have added this here.
Maybe I was using it to investigate something ... It might perhaps be
useful to add a test which uses this to make sure the VSP1 is happy with
late queued frames?
>> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
>> ---
>> scripts/vsp-lib.sh | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
>> index 9140254c7459..3d2792707d24 100755
>> --- a/scripts/vsp-lib.sh
>> +++ b/scripts/vsp-lib.sh
>> @@ -898,6 +898,7 @@ vsp_runner() {
>> local count=10
>> local pause=
>> local skip=7
>> + local queue_late=
>>
>> for option in $* ; do
>> case $option in
>> @@ -916,6 +917,8 @@ vsp_runner() {
>> --skip=*)
>> skip=${option/--skip=/}
>> ;;
>> + --queue-late)
>> + queue_late=queue-late
erm ... missing ";;"?
>>
>> *)
>> return 1
>> @@ -959,6 +962,7 @@ vsp_runner() {
>>
>> $yavta -c$count -n $buffers ${format:+-f $format} ${size:+-s $size} \
>> ${skip:+--skip $skip} ${file:+--file=$file} ${pause:+-p$pause} \
>> + ${queue_late:+--$queue_late} \
>> $videodev | ./logger.sh $entity >> $logfile
>> }
>>
>
--
Regards
--
Kieran
