Hi Kieran,
Thank you for the patch.
On Tue, Dec 04, 2018 at 03:51:42PM +0000, Kieran Bingham wrote:
> Extend the vsp-lib to support command line parsing for all tests. The
> arguments parsed here should be common to all tests, and initially
> provide shell level verbose debug output, and the option to easily keep
> frames output by the VSP1.
>
> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> ---
> scripts/vsp-lib.sh | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
> index 0f3992a7827e..56969606382f 100755
> --- a/scripts/vsp-lib.sh
> +++ b/scripts/vsp-lib.sh
> @@ -1094,3 +1094,37 @@ test_complete() {
> test_run() {
> test_main | ./logger.sh error >> $logfile
> }
> +
> +# ------------------------------------------------------------------------------
> +# Common argument parsing
> +#
> +# non-recognised arguments are restored, to allow tests to implement their own
> +# parsing if necessary.
> +
> +POSITIONAL=()
This work in bash only :-( Any chance to implement a solution that would
work in ash too ?
> +while [[ $# -gt 0 ]]
> +do
> +case $1 in
> + -x|--debug)
> + set -x;
> + shift
> + ;;
> + -k|--keep-frames)
> + export VSP_KEEP_FRAMES=1
> + shift
> + ;;
> + -h|--help)
> + echo "$(basename $0): VSP Test library"
> + echo " -x|--debug enable shell debug"
> + echo " -k|--keep-frames keep generated and captured frames"
> + echo " -h|--help this help"
> + exit
> + shift
> + ;;
> + *) # unknown option
> + POSITIONAL+=("$1") # save it in an array for later
> + shift # past argument
> + ;;
> +esac
> +done
> +set -- "${POSITIONAL[@]}" # restore positional parameters
--
Regards,
Laurent Pinchart
