On 2/10/19 2:39 PM, Niklas Söderlund wrote: > Hi Wolfram, Hi, > Thanks for your patch. > > On 2019-02-08 20:30:02 +0100, Wolfram Sang wrote: >> From: Takeshi Saito <takeshi.saito.xv@xxxxxxxxxxx> >> >> SCC is used for SDR104/HS200/HS400. We need to change SCC_DT2FF >> according to the mode. If it is inappropriate, CRC error tends to occur. >> >> This adds variable "tap_hs400" for HS400 mode and configures SCC_DT2FF >> as needed. >> >> Signed-off-by: Takeshi Saito <takeshi.saito.xv@xxxxxxxxxxx> >> [wsa: rebased to upstream and updated commit message] >> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > I think this looks good. > > Reviewed-by: Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> Can you test this on E3 Ebisu (do you have a board) ? -- Best regards, Marek Vasut