Hi Simon,
On Fri, Jan 4, 2019 at 2:27 PM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Mon, Dec 03, 2018 at 09:25:30AM +0100, Geert Uytterhoeven wrote:
> > On Sat, Dec 1, 2018 at 3:43 PM Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
> > > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > >
> > > This patch adds the regulator definition required for operation of
> > > S2RAM.
> > >
> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > > @@ -425,6 +425,26 @@
> > > };
> > > };
> > >
> > > +&i2c_dvfs {
> > > + status = "okay";
> > > +
> > > + clock-frequency = <400000>;
> > > +
> > > + pmic: pmic@30 {
> > > + pinctrl-0 = <&irq0_pins>;
> > > + pinctrl-names = "default";
> > > +
> > > + compatible = "rohm,bd9571mwv";
> > > + reg = <0x30>;
> > > + interrupt-parent = <&intc_ex>;
> > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > > + interrupt-controller;
> > > + #interrupt-cells = <2>;
> > > + gpio-controller;
> > > + #gpio-cells = <2>;
> >
> > Just adding this node is not sufficient to make S2RAM work.
> > As per Documentation/devicetree/bindings/mfd/bd9571mwv.txt, you also have
> > to describe the DDR-Backup Power configuration.
> >
> > On the Ebisu-4D development board, only the DDR0 power rail is used, and
> > needs to be kept powered when backup mode is enabled.
> >
> > rohm,ddr-backup-power = <0x1>;
> > rohm,rstbmode-level;
> >
> > Unfortunately resume from s2ram doesn't work with this, probably due to an
> > issue in ATF. This may have been fixed in IPL and Secure Monitor Rev1.0.22,
> > which claims to add support for the Ebisu-4D board.
>
> Thanks, do you know of any information on how to get IPL and Secure Monitor
> running / updated on Ebisu-4D?
This is now working with upstream ATF (v2.0-763-ga45ccf135e48efc7)
> > I don't know if plain Ebisu needs a different configuration.
> >
> > > + };
> > > +};
> > > +
> > > &lvds0 {
> > > status = "okay";
> > >
> >
> > The rest is fine, hence with the above fixed and tested:
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> I assume that working S2RAM is part of such testing.
> Is that correct?
That is correct.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
