Re: [renesas-drivers:topic/clk-r8a77990-z2-v3 11/13] rcar-gen3-cpg.c:undefined reference to `__udivdi3'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 6, 2019 at 12:38 AM kbuild test robot <lkp@xxxxxxxxx> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git topic/clk-r8a77990-z2-v3
> head:   3423d0ef4af282d1a1021b40cc2e739c08c9046b
> commit: 0961e355977f7806b926ea0ae29c5cffa7867894 [11/13] clk: renesas: rcar-gen3: Support Z and Z2 clocks with high frequency parents
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
> reproduce:
>         git checkout 0961e355977f7806b926ea0ae29c5cffa7867894
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>    ld: drivers/clk/renesas/rcar-gen3-cpg.o: in function `cpg_z_clk_set_rate':
> >> rcar-gen3-cpg.c:(.text+0x13c): undefined reference to `__udivdi3'

Thanks for the report!

I guess this is due to

+       mult = DIV_ROUND_CLOSEST(rate * 32ULL * zclk->fixed_div, parent_rate);

While Simon had tested this on arm, apparently it fails on (at least) i386
and mips.

Changing "32ULL" to "32UL" should fix this, but means a sure overflow if this
code is ever used on or copied for a 32-bit platform.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux