Hello!
On 01/29/2019 09:20 PM, Geert Uytterhoeven wrote:
>> The R-Mobile A1 (R8A7740) SoC manual describes the Ether MAC's RX checksum
>> offload the same way as it's implemented in the EtherAVB MAC...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> Running netperf as described in patch 2/7, perf tells me there's a reduction
> for csum_partial from ca. 1.9% to 0.01%, so this feature seems to work.
Hm, what about do_csum()?
> Hence:
> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thank you!
> However, while effective according to perf results, using ethtool to
> enable/disable
> the feature prints an error message:
>
> root@armadillo:~# ethtool -K eth0 rx on
> Cannot get device udp-fragmentation-offload settings: Operation not supported
> Cannot get device udp-fragmentation-offload settings: Operation not supported
> root@armadillo:~# ethtool -K eth0 rx off
> Cannot get device udp-fragmentation-offload settings: Operation not supported
> Cannot get device udp-fragmentation-offload settings: Operation not supported
> root@armadillo:~#
>
> Do you have any clue?
No (I'm seeing the same).
> Does this needs testing on R-Mobile A1 with VLAN enabled, too, or is that
> independent from the underlying sh-eth hardware version?
It's dependent...
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
