On Tue, Jan 29, 2019 at 01:37:38PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/29/2019 11:00 AM, Simon Horman wrote: > > >>>> The RZ/A1H (R7S721000) SoC manual describes the Ether MAC's RX checksum > >>>> offload the same way as it's implemented in the EtherAVB MACs... > >>>> > >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > >>> > >>> Regarding this and the remaining patches in this series, > >>> which add rx-csum offload support in the sh_eth driver for > >>> various SoCs: has this been tested? > >> > >> As I said, I've only tested it on R8A77980. > > And still hoping Geert would be able to test on R8A7740. > > > > > Thanks, I missed that. > > > > As you may have guessed the implication of my question is that > > IMHO it would be best only to add this feature to SoCs where > > it has been tested. > > You don't trust the manuals? :-) As a rule I do not. But sometimes I have to anyway.