On 1/29/19 9:05 AM, Ulf Hansson wrote: > On Tue, 29 Jan 2019 at 06:40, <marek.vasut@xxxxxxxxx> wrote: >> >> From: Takeshi Saito <takeshi.saito.xv@xxxxxxxxxxx> >> >> This fixes card initialization failure in high speed mode. >> >> If U-Boot uses SDR or HS200/400 mode before starting Linux and Linux >> DT does not enable SDR/HS200/HS400 mode, card initialization fails in >> high speed mode. >> >> It is necessary to initialize SCC registers during card initialization >> phase. HW reset function is registered only for a port with either of >> SDR/HS200/HS400 properties in device tree. If SDR/HS200/HS400 properties >> are not present in device tree, SCC registers will not be reset. In SoC >> that support SCC registers, HW reset function should be registered >> regardless of the configuration of device tree. >> >> Reproduction procedure: >> - Use U-Boot that support MMC HS200/400 mode. >> - Delete HS200/HS400 properties in device tree. >> (Delete mmc-hs200-1_8v and mmc-hs400-1_8v) >> - MMC port works high speed mode and all commands fail. >> >> Signed-off-by: Takeshi Saito <takeshi.saito.xv@xxxxxxxxxxx> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> Cc: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> >> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> >> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx >> To: linux-mmc@xxxxxxxxxxxxxxx > > Is this a regression? No, because this was broken since the beginning. But U-Boot HS200/HS400 support is now, so this bug was hidden. > Should it be tagged for stable? I am tempted to say yes. -- Best regards, Marek Vasut
