On 01/28/2019 12:21 PM, Geert Uytterhoeven wrote:
> On Sun, Jan 27, 2019 at 6:40 PM Sergei Shtylyov
> <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
>> Commit 62e04b7e0e3c ("sh_eth: rename 'sh_eth_cpu_data::hw_crc'") renamed
>> the field to 'hw_checksum' for the Ether DMAC "intelligent checksum",
>> however some Ether MACs implement a simpler checksumming scheme, so that
>> name now seems misleading. Rename that filed to 'csmr' as the "intelligent
>> checkmum" is always controlled by the CSMR register.
>
> checksum
Oops! Do I need to repost?
>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> Apart from that:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
>> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
>> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
>
>> @@ -793,7 +793,7 @@ static struct sh_eth_cpu_data r8a77980_d
>> .no_trimd = 1,
>> .no_ade = 1,
>> .xdfar_rw = 1,
>> - .hw_checksum = 1,
>> + .csmr = 1,
>
> Interestingly, I cannot find the CSMR register in the R-Car Gen3 docs?
Me niether... But if you remove that flag, the driver stops working due to
not doing >>= 16 in sh_eth_rx() anymore. Go figure... :-)
> Not introduced by this patch, though.
Yep.
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
