Hi Geert-san, Thanks for your review! 2019年1月17日(木) 1:38 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>: > > Hi Kaneko-san, > > On Tue, Jan 15, 2019 at 1:01 PM Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > > > This patch adds DRIF{0,1,2,3} pins, groups and functions to the R8A77990 > > SoC. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > Thanks for your patch! > > > --- a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c > > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c > > > @@ -3523,7 +3716,7 @@ enum { > > }; > > > > static const struct { > > - struct sh_pfc_pin_group common[241]; > > + struct sh_pfc_pin_group common[262]; > > struct sh_pfc_pin_group automotive[2]; > > } pinmux_groups = { > > .common = { > > @@ -3555,6 +3748,27 @@ enum { > > SH_PFC_PIN_GROUP(can0_data), > > SH_PFC_PIN_GROUP(can1_data), > > SH_PFC_PIN_GROUP(can_clk), > > + SH_PFC_PIN_GROUP(drif0_ctrl_a), > > + SH_PFC_PIN_GROUP(drif0_data0_a), > > + SH_PFC_PIN_GROUP(drif0_data1_a), > > + SH_PFC_PIN_GROUP(drif0_ctrl_b), > > + SH_PFC_PIN_GROUP(drif0_data0_b), > > + SH_PFC_PIN_GROUP(drif0_data1_b), > > + SH_PFC_PIN_GROUP(drif1_ctrl), > > + SH_PFC_PIN_GROUP(drif1_data0), > > + SH_PFC_PIN_GROUP(drif1_data1), > > + SH_PFC_PIN_GROUP(drif2_ctrl_a), > > + SH_PFC_PIN_GROUP(drif2_data0_a), > > + SH_PFC_PIN_GROUP(drif2_data1_a), > > + SH_PFC_PIN_GROUP(drif2_ctrl_b), > > + SH_PFC_PIN_GROUP(drif2_data0_b), > > + SH_PFC_PIN_GROUP(drif2_data1_b), > > + SH_PFC_PIN_GROUP(drif3_ctrl_a), > > + SH_PFC_PIN_GROUP(drif3_data0_a), > > + SH_PFC_PIN_GROUP(drif3_data1_a), > > + SH_PFC_PIN_GROUP(drif3_ctrl_b), > > + SH_PFC_PIN_GROUP(drif3_data0_b), > > + SH_PFC_PIN_GROUP(drif3_data1_b), > > As RZ/G2E (r8a774c0) does not have the DRIF modules, the DRIF pin groups > should be added to the automotive section, instead of the common section. I will do that. > > > SH_PFC_PIN_GROUP(du_rgb666), > > SH_PFC_PIN_GROUP(du_rgb888), > > SH_PFC_PIN_GROUP(du_clk_in_0), > > > @@ -4157,7 +4404,7 @@ enum { > > }; > > > > static const struct { > > - struct sh_pfc_function common[44]; > > + struct sh_pfc_function common[48]; > > struct sh_pfc_function automotive[2]; > > } pinmux_functions = { > > .common = { > > @@ -4166,6 +4413,10 @@ enum { > > SH_PFC_FUNCTION(can0), > > SH_PFC_FUNCTION(can1), > > SH_PFC_FUNCTION(can_clk), > > + SH_PFC_FUNCTION(drif0), > > + SH_PFC_FUNCTION(drif1), > > + SH_PFC_FUNCTION(drif2), > > + SH_PFC_FUNCTION(drif3), > > Likewise for the DRIF pin functions. Likewise. > > > SH_PFC_FUNCTION(du), > > SH_PFC_FUNCTION(hscif0), > > SH_PFC_FUNCTION(hscif1), > > The rest looks good to me, so with the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Best regards, Kaneko