On 1/23/19 8:09 AM, Mason Yang wrote:
> Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller.
>
> Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
[...]
> +#define RPC_CMNCR 0x0000 // R/W
Is there any reason for using those horrible C++ comments ?
[...]
> +module_platform_driver(rpc_spi_driver);
RPC is not a SPI controller, it's a SPI and HF controller.
Also, how difficult will it be to add the HF support ?
> +MODULE_AUTHOR("Mason Yang <masonccyang@xxxxxxxxxxx>");
> +MODULE_DESCRIPTION("Renesas R-Car Gen3 RPC-IF SPI controller driver");
> +MODULE_LICENSE("GPL v2");
>
--
Best regards,
Marek Vasut
