On Thu, Jan 17, 2019 at 04:01:26PM +0100, Wolfram Sang wrote:
> On Thu, Jan 17, 2019 at 03:38:29PM +0100, Simon Horman wrote:
> > Add SDHI3 UHS pin control and use it when enabling HS200 support
> > for SDHI3.
>
> HS400
>
> > # dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512 iflag=direct
> > 512+0 records in
> > 512+0 records out
> > 536870912 bytes (537 MB) copied, 9.02486 s, 59.5 MB/s
> > # dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512 iflag=direct
> > 512+0 records in
> > 512+0 records out
> > 536870912 bytes (537 MB) copied, 7.36003 s, 72.9 MB/s
> > # dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512 iflag=direct
> > 512+0 records in
> > 512+0 records out
> > 536870912 bytes (537 MB) copied, 11.0156 s, 48.7 MB/s
>
> Hmmmm, quite some fluctuation and far away from the performances of M3N.
Perhaps the M3N measurements were taken without iflag=direct ?
In that case for E3 I see:
# dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512
512+0 records in
512+0 records out
536870912 bytes (537 MB) copied, 3.79686 s, 141 MB/s
# dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512
512+0 records in
512+0 records out
536870912 bytes (537 MB) copied, 3.77128 s, 142 MB/s
# dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512
512+0 records in
512+0 records out
536870912 bytes (537 MB) copied, 3.79916 s, 141 MB/s
> Marek, do you have an idea why? Did you note any E3 differences when
> coding support for U-Boot?
>
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > index 89383aa35d65..f2846c9eb83f 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > @@ -535,6 +535,12 @@
> > power-source = <1800>;
> > };
> >
> > + sdhi3_pins_uhs: sd3_uhs {
> > + groups = "sdhi3_data8", "sdhi3_ctrl", "sdhi3_ds";
> > + function = "sdhi3";
> > + power-source = <1800>;
> > + };
> > +
>
> This is exactly the same as sdhi3_pins, so no need.
Yes, silly me.
