Hi Fabrizio, Thanks for your patch! On Wed, Jan 16, 2019 at 7:39 PM Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> wrote: > This patch adds the missing CANFD clock to the r8a774c0 specific > clock driver. Are you sure the CANFD clock exists on RZ/G2E? > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > Reviewed-by: Chris Paterson <Chris.Paterson2@xxxxxxxxxxx> > --- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c > --- a/include/dt-bindings/clock/r8a774c0-cpg-mssr.h > +++ b/include/dt-bindings/clock/r8a774c0-cpg-mssr.h > @@ -48,13 +48,14 @@ > #define R8A774C0_CLK_ZA2 37 > #define R8A774C0_CLK_ZA8 38 > #define R8A774C0_CLK_Z2D 39 > -#define R8A774C0_CLK_MSO 40 > -#define R8A774C0_CLK_R 41 > -#define R8A774C0_CLK_OSC 42 > -#define R8A774C0_CLK_LV0 43 > -#define R8A774C0_CLK_LV1 44 > -#define R8A774C0_CLK_CSI0 45 > -#define R8A774C0_CLK_CP 46 > -#define R8A774C0_CLK_CPEX 47 > +#define R8A774C0_CLK_CANFD 40 > +#define R8A774C0_CLK_MSO 41 > +#define R8A774C0_CLK_R 42 > +#define R8A774C0_CLK_OSC 43 > +#define R8A774C0_CLK_LV0 44 > +#define R8A774C0_CLK_LV1 45 > +#define R8A774C0_CLK_CSI0 46 > +#define R8A774C0_CLK_CP 47 > +#define R8A774C0_CLK_CPEX 48 This file is part of the DT ABI, hence list of definitions is append-only. Please add R8A774C0_CLK_CANFD at the end, i.e. #define R8A774C0_CLK_CANFD 48 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds