Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:25AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Links are validated along the pipeline which is about to start streaming. > Not all the pads in entities that are traversed along that pipeline are > part of the pipeline, however. Skip the link validation for such pads. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/media-entity.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index 4d10bc186e1e7a10..cdf3805dec755ec5 100644 > --- a/drivers/media/media-entity.c > +++ b/drivers/media/media-entity.c > @@ -493,6 +493,11 @@ __must_check int __media_pipeline_start(struct media_pad *pad, > struct media_pad *other_pad = link->sink->entity == entity > ? link->sink : link->source; > > + /* Ignore pads to which there is no route. */ > + if (!media_entity_has_route(entity, pad->index, > + other_pad->index)) > + continue; > + > /* Mark that a pad is connected by a link. */ > bitmap_clear(has_no_links, other_pad->index, 1); > -- Regards, Laurent Pinchart
