Hi Sergei, On Wed, Jan 9, 2019 at 7:47 PM Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 01/08/2019 07:16 AM, Mason Yang wrote: > > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > > > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> > > You now need to add: > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > --- a/drivers/spi/Kconfig > > +++ b/drivers/spi/Kconfig > > @@ -544,6 +544,12 @@ config SPI_RSPI > > help > > SPI driver for Renesas RSPI and QSPI blocks. > > > > +config SPI_RENESAS_RPC_IF > > Since the driver is called without -IF suffix, I wouldn't use it in the > Kconfig name either, the following is enough: > > > + tristate "Renesas R-Car Gen3 RPC-IF SPI controller" > > + depends on ARCH_RENESAS || COMPILE_TEST > > Judging on the compilation error reported by the 0-day bot about readq(), > we now need to depend on 64BIT or something... IIRC, this hardware block is also used on RZ/A, which is 32-bit. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds