Hi Simon, On Fri, Jan 4, 2019 at 9:57 AM Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote: > > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote: > > > Enable the R-Car thermal driver as a built-in. > > > > > > This driver is used in conjunction with the R-Car V3M (r8a77970), > > > E3 (r8a77990) and D3 (r8a77995) SoCs. > > > > > [v2] Enable as a built-in rather than a module as this seems > > > safer from the point of view of protecting equipment from > > > overheating. > > > > Shouldn't the above paragraph be moved below the ---? > > I have recently come to believe that its a matter of taste. And I think in > this case it captures important information that is worthy of inclusion in > the changelog. The rationale behind doing it this way could still be appended to the first line of the body of the patch decription. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds