On 12/17/2018 07:12 PM, Wolfram Sang wrote: > >> + if (!IS_ERR(tzd)) { >> + tzd->tzp = tzp; > > I tried to read the thermal core but couldn't really figure it. We are > not leaking/overwriting the tzp pointer acquired in of-thermal.c here? I think so, and Eduardo seem to be confirming it, albeit it's rather inobvious. -- Best regards, Marek Vasut