On Thu, Dec 13, 2018 at 07:27:10PM +0100, Geert Uytterhoeven wrote: > The debug code in sh_pfc_write_config_reg() prints the width of the > field being modified. > > However, registers with a variable-width field layout are identified by > pinmux_cfg_reg.field_width being zero, hence zeroes are printed instead > of the actual field widths. > > Fix this by printing the Hamming height of the field mask instead, which > is correct for both fixed-width and variable-width fields. s/height/width ? > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > --- > drivers/pinctrl/sh-pfc/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c > index a10f7050a74f35ff..f1cfcc8c65446662 100644 > --- a/drivers/pinctrl/sh-pfc/core.c > +++ b/drivers/pinctrl/sh-pfc/core.c > @@ -221,7 +221,7 @@ static void sh_pfc_write_config_reg(struct sh_pfc *pfc, > > dev_dbg(pfc->dev, "write_reg addr = %x, value = 0x%x, field = %u, " > "r_width = %u, f_width = %u\n", > - crp->reg, value, field, crp->reg_width, crp->field_width); > + crp->reg, value, field, crp->reg_width, hweight32(mask)); > > mask = ~(mask << pos); > value = value << pos; > -- > 2.17.1 >
