RE: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

[Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>]

Hello Andrew, Florian,

> From: Andrew Lunn, Sent: Tuesday, December 4, 2018 7:44 PM
> 
> > > Series applied, thank you.
> >
> > Meh! I guess we should be faster at reviewing stuff :/
> 
> And there have been things going on behind the scenes to try to get a
> real fix. Sorry, i should of mentioned that.

Sorry for the delayed response. How to try to get a real fix?
I have two ideas:

Idea 1: Assert/deassert the reset in phy_{suspend,resume}()
 - call phy_device_reset(phydev, 0); if !phydev->attached_dev in phy_suspend()
 - call phy_device_reset(phydev, 1); if !phydev->attached_dev in phy_resume()

Idea 2: Toggle the reset in phy_resume().
 - call phy_device_reset(phydev, 0); udelay(1); phy_device_reset(phydev, 1);
   if !phydev->attached_dev in phy_resume ()

I think the idea 1 is better. But, what do you think?

Best regards,
Yoshihiro Shimoda