Re: [PATCH v2] nvmem: check invalid number of bytes in nvmem_{read,write}()

To: Biju Das <biju.das@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v2] nvmem: check invalid number of bytes in nvmem_{read,write}()
From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Date: Mon, 10 Dec 2018 18:34:09 +0000
Cc: Simon Horman <horms@xxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>, linux-rtc@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx
In-reply-to: <1544455701-5720-1-git-send-email-biju.das@bp.renesas.com>
References: <1544455701-5720-1-git-send-email-biju.das@bp.renesas.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1



On 10/12/18 15:28, Biju Das wrote:

+	/* Stop the user from writing */
+	if (offset >= nvmem->size)
+		return -ENOSPC;
+

This should be "return -EFBIG" to make utilities like dd or sh happy.

Look at 38b0774c0598c ("nvmem: core: return EFBIG on out-of-rangewrite") for more info.


other than that, patch looks fine to me!

--srini

Follow-Ups:
- RE: [PATCH v2] nvmem: check invalid number of bytes in nvmem_{read,write}()
  - From: Biju Das

References:
- [PATCH v2] nvmem: check invalid number of bytes in nvmem_{read,write}()
  - From: Biju Das