Re: [PATCH v4 1/5] nvmem: check invalid number of bytes in nvmem_device_{read,write}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/12/18 12:45, Biju Das wrote:
Its better to move checks from
bin_attr_nvmem_read()/bin_attr_nvmem_write() into nvmem_reg_read()
and nvmem_reg_write(), so its easy to maintain, rather than adding them to
each function.
Initially I also thought the same. But there are some RTC drivers which is using nvmem_device
interface  is not defining "word_size"  member. That is the reason we need to add it in separate function.
Can you please suggest how to handle the above drivers?

Word size is optional anyway, in the case where word_size is not specified, its considered as one byte word_size.

--srini





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux