Hi Shimoda-san, Thank you for the patches. On Friday, 7 December 2018 10:29:28 EET Yoshihiro Shimoda wrote: > This patch adds support for PWM "atomic" API. > > This patch also adds a workaround to output "pseudo" low level. > Otherwise, the PWM backlight driver doesn't work correctly, especially > it cannot output maximum brightness actually. > > Yoshihiro Shimoda (5): > pwm: rcar: add rcar_pwm_calc_counter() to calculate PWMCNT value only > pwm: rcar: Add support "atomic" API > pwm: rcar: Use "atomic" API on rcar_pwm_resume() > pwm: rcar: remove legacy APIs > pwm: rcar: add workaround to output "pseudo" low level > > drivers/pwm/pwm-rcar.c | 108 ++++++++++++++++++++++++++-------------------- > 1 file changed, 62 insertions(+), 46 deletions(-) For the whole series, Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> with backlight on the Draak board. I do however agree with Uwe's comments. -- Regards, Laurent Pinchart