On 12/07/2018 05:03 PM, Sergei Shtylyov wrote: > Hello! > > On 12/07/2018 02:13 PM, Mason Yang wrote: > >> Document the bindings used by the Renesas R-Car Gen3 RPC controller. >> >> Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> >> --- >> .../devicetree/bindings/spi/spi-renesas-rpc.txt | 38 ++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> new file mode 100644 >> index 0000000..a191f70 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> @@ -0,0 +1,38 @@ >> +Renesas R-Car Gen3 RPC controller Device Tree Bindings >> +------------------------------------------------------ >> + >> +Required properties: >> +- compatible: should be "renesas,r8a77995-rpc" >> +- #address-cells: should be 1 >> +- #size-cells: should be 0 >> +- reg: should contain 2 entries, one for the registers and one for the direct >> + mapping area >> +- reg-names: should contain "rpc_regs" and "dirmap" > > Please drop this "rpc_" thing, I think "regs" should be enough. > >> +- interrupts: interrupt line connected to the RPC controller >> +- clock-names: should contain "clk_rpc" > > Please drop this "clk_" thing. BTW, what's with the RPCD2 clock? > >> +- clocks: should contain 1 entries for the module's clock >> +- rpc-mode: should contain "rpc-spi-flash" for rpc spi mode or >> + "rpc-hyperflash" for rpc hyerflash mode. > > I think the prop should be called "renesas,rpc-mode" and the values should be > just "spi" and "hyperflash". Like I said before, you can determine the mode from the subnode attached to the controller, we don't need special prop for that. -- Best regards, Marek Vasut
