Hello Linus, Thank you for your feedback! > From: Linus Walleij <linus.walleij@xxxxxxxxxx> > Sent: 05 December 2018 21:46 > Subject: Re: [RFC v3 1/2] pinctrl: core: Add pinctrl_mux_gpio_request_enable > > On Tue, Nov 20, 2018 at 4:19 PM Fabrizio Castro > <fabrizio.castro@xxxxxxxxxxxxxx> wrote: > > > Sometimes there is the need to change the muxing of a pin to make it > > a GPIO without going through gpiolib. > > This patch adds pinctrl_mux_gpio_request_enable to deal with this new > > use case from code that has nothing to do with pinctrl. > > It has a lot to do with pinctrl I think, so I get confused by this > commit message. I can improve that > > > extern int pinctrl_gpio_request(unsigned gpio); > > +extern int pinctrl_mux_gpio_request_enable(unsigned gpio); > > What's wrong with just using the existing call > pinctrl_gpio_request() right above your new one? > > It's not like we're reference counting or something, it's just > a callback. Sprinkle some comments to show what's going > on. I tried that, and it was working for me, then something changed lately in gpiolib that broke that solution, and Geert picked it up on his end. Please see this: https://patchwork.kernel.org/patch/10671325/ This patch was made to overcome the problems of the previous patch. > > If you for some reason need a new call for this specific > use case, it needs to be named after the use case, > like pinctrl_gpio_request_for_irq() > so it is obvious what the function is doing. I can do that, but I would like to hear from Geert first, no point in going around in circle if this solution is not acceptable to him. Geert, what do you think? Thanks! Fab > > Yours, > Linus Walleij [https://www2.renesas.eu/media/email/unicef.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
