On 12/05/2018 03:39 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Sun, Dec 2, 2018 at 8:36 PM Marek Vasut <marek.vasut@xxxxxxxxx> wrote: >> It is possible that the PCA953x is powered down during suspend. >> Use regmap cache to assure the registers in the PCA953x are in >> line with the driver state after resume. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > >> +static int pca953x_suspend(struct device *dev) >> +{ >> + struct pca953x_chip *chip = dev_get_drvdata(dev); >> + >> + regcache_mark_dirty(chip->regmap); >> + pca953x_regcache_sync(dev); >> + regcache_cache_only(chip->regmap, true); > > Based on the discussion about adding suspend/resume support to the VC5 > clock driver, I guess the two sync calls above are not needed here? Yes -- Best regards, Marek Vasut