Hi Biju, On Fri, Nov 30, 2018 at 11:43 AM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > > Subject: Re: [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support > > > > On Tue, Nov 27, 2018 at 1:05 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > > > Add eMMC support for iWave RZ/G1N Qseven System On Module. > > > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > I assume the PCB is the same for RZ/G1M and RZ/G1N, so perhaps this can > > be factored out in a common .dtsi file, like we did for Salvator-X(S)? > > SoM is different between RZ/G1M and RZ/G1N in terms of memory and PCie/SATA. > > The only common part in SoM is eMMC,SDHI0 and QSPI flash. So it doesn't make sense to factored it out. > > What do you think? OK, then it's fine for me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds