Hi Niklas, Thank you for the patch. On Thursday, 29 November 2018 04:01:44 EET Niklas Söderlund wrote: > The CSI-2 transmitters can use a different number of lanes to transmit > data. Make the data-lanes mandatory for the endpoints that describe the > transmitters as no good default can be set to fallback on. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > * Changes since v3 > - Add paragraph to describe the accepted values for the source endpoint > data-lane property. Thanks Jacopo for pointing this out and sorry for > missing this in v2. > * Changes since v2 > - Update paragraph according to Laurents comments. > --- > .../devicetree/bindings/media/i2c/adv748x.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index > 5dddc95f9cc46084..4f91686e54a6b939 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -48,7 +48,16 @@ are numbered as follows. > TXA source 10 > TXB source 11 > > -The digital output port nodes must contain at least one endpoint. > +The digital output port nodes, when present, shall contain at least one > +endpoint. Each of those endpoints shall contain the data-lanes property as > +described in video-interfaces.txt. > + > +Required source endpoint properties: > + - data-lanes: an array of physical data lane indexes > + The accepted value(s) for this property depends on which of the two > + sources are described. For TXA 1, 2 or 4 data lanes can be described > + while for TXB only 1 data lane is valid. See video-interfaces.txt > + for detailed description. > > Ports are optional if they are not connected to anything at the hardware > level. -- Regards, Laurent Pinchart
