Hi Shimoda-san, On Wed, Nov 28, 2018 at 7:10 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > Some R-Car Gen3 SoCs has hardware restrictions on the IPMMU. So, > to check whether this R-Car Gen3 SoC can use the IPMMU correctly, > this patch modifies the ipmmu_slave_whitelist(). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> One question below. > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -771,11 +765,35 @@ static bool ipmmu_slave_whitelist(struct device *dev) > { /* sentinel */ } > }; > > +static const struct soc_device_attribute soc_rcar_gen3_whitelist[] = { > + { .soc_id = "r8a7795", .revision = "ES3.0" }, Don't you want "ES3.*"? > + { .soc_id = "r8a77965", }, > + { .soc_id = "r8a77990", }, > + { .soc_id = "r8a77995", }, > + { /* sentinel */ } > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds