Hi Andrew, > From: Andrew Lunn, Sent: Wednesday, November 28, 2018 1:44 AM > > On Tue, Nov 27, 2018 at 12:18:20PM +0000, Yoshihiro Shimoda wrote: > > Some PHY device needs edge signal of the reset, but the previous code > > is impossible to achieve it like following: > > > > 1) Kernel boots by using initramfs. > > --> No open the nic, so the provious code deasserts the reset by > > phy_device_register() and phy_probe(). > > 2) Kernel enters the suspend. > > --> So, keep the reset signal as deassert. > > --> On R-Car Salvator-XS board, unfortunately, the board power is > > turned off. > > 3) Kernel returns from suspend. > > 4) ifconfig eth0 up > > --> Then, since edge signal of the reset doesn't happen, > > it cannot link up. > > Hi Yoshihiro > > It sounds like you should be adding code to the suspend/resume > handling of phylib, so that it toggle the reset on resume. You cannot > just delete code like you proposed, it is going to break devices. But > adding code should be O.K. Thank you for your comment! I understood we cannot delete the code, but can add the suspend/resume handling of phylib. I'll make such a patch. Best regards, Yoshihiro Shimoda
