On 11/21/2018 01:53 AM, masonccyang@xxxxxxxxxxx wrote: > Hi Marek, Hi, >> Marek Vasut <marek.vasut@xxxxxxxxx> >> 2018/11/20 下午 08:57 >> >> >> > diff --git a/Documentation/devicetree/bindings/spi/spi-renesas- >> >> rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> >> > new file mode 100644 >> >> > index 0000000..8286cc8 >> >> > --- /dev/null >> >> > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> >> > @@ -0,0 +1,33 @@ >> >> > +Renesas R-Car D3 RPC controller Device Tree Bindings >> >> > +---------------------------------------------------- >> >> > + >> >> > +Required properties: >> >> > +- compatible: should be "renesas,rpc-r8a77995" >> >> > +- #address-cells: should be 1 >> >> > +- #size-cells: should be 0 >> >> > +- reg: should contain 2 entries, one for the registers and one >> >> for the direct >> >> > + mapping area >> >> > +- reg-names: should contain "rpc_regs" and "dirmap" >> >> > +- interrupts: interrupt line connected to the RPC SPI controller >> >> >> >> Do you also plan to support the RPC HF mode ? And if so, how would that >> >> look in the bindings ? I'd like to avoid having to redesign the > bindings >> >> later to handle both the SPI and HF modes. >> >> >> > >> > I patched this RPC SPI/Octa driver is for mx25uw51245g and you may also >> > refer to Boris's patch. [1][2][3] >> >> Does this mean the driver is specific to one particular kind of flash ? >> > > No, this driver supports all SPI flash, spi, qspi and octa flash. > > The target is Octa 8-8-8 DDR2 mode once spi-nor layer is merged.[1][2][3] The HyperFlash must also be supported, cfr my previous comment that I'd like to avoid redesigning the bindings again when the HF mode is added. -- Best regards, Marek Vasut
