On 2018-11-19 14:26, Fabrizio Castro wrote:
> kbuild test robot reports:
>
>>> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
> undefined!
>>> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
> undefined!
>>> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
> undefined!
Hi!
My preference would be to not wrap the quoted text. To hell with
warnings about long lines for cases like this. However, I'm not
going to require a new iteration for that detail, but keep that
in mind for the next patch or if you end up resending for some
unrelated reason.
>
> Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> introduces a recursive dependency, therefore this patch selects I2C_MUX
> instead.
This driver will not be the first to select I2C_MUX. So, even if it
it is a bit untidy to select stuff that is also selectable by the
user...
Acked-by: Peter Rosin <peda@xxxxxxxxxx>
>
> Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")
> Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> ---
> v2->v3:
> * Changed the title
>
> v1->v2:
> * Added "Fixes" tag
>
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 9eeb8ef..2fee47b 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -95,6 +95,7 @@ config DRM_SII902X
> depends on OF
> select DRM_KMS_HELPER
> select REGMAP_I2C
> + select I2C_MUX
> ---help---
> Silicon Image sii902x bridge chip driver.
>
>
