Hello Phil, On Mon, Nov 19, 2018 at 12:53:46PM +0000, Phil Edworthy wrote: > On 19 November 2018 10:46 Uwe Kleine-König wrote: > > On Mon, Nov 19, 2018 at 10:41:42AM +0000, Phil Edworthy wrote: > > > btw, do we need to add of_clk_get_by_name_optional()? I only added it > > > as a counterpart to of_clk_get_by_name(), but it may not be needed. > > > > I don't need it. Given that it is easy to add when someone has a need, I'd say, > > skip it for now. > > I'm wondering if we actually need clk_get_optional(). For me at least, I just > want devm_clk_get_optional(). That would get rid of the arch patches. Given that clk_get_optional will be that simple, it can live in linux/clk.h for all implementors of the clk API, then you don't have to care about different archs. (Unless I'm missing something.) I don't think it's a good idea to drop clk_get_optional even if you'd have to provide arch-specific stuff. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
