On 11/06/2018 12:15 PM, Wolfram Sang wrote: > On Mon, Nov 05, 2018 at 10:40:12PM +0100, Marek Vasut wrote: >> From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> >> >> This patch supports the {get,set}_io_voltage operations of SDHI. >> >> This operates the IOCTRL30 register on the R8A77990 SoC and makes >> 1.8V/3.3V signal voltage switch possible. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> >> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > > Looks good from a high-level point of view. Didn't check the actual > values. I trust Shimoda-san and Geert for that: > > Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > I also checked them in U-Boot :) -- Best regards, Marek Vasut