Hi Biju, On Fri, Oct 26, 2018 at 11:40 AM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > This patch adds watchdog support to the r8a77470 SoC dtsi. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm/boot/dts/r8a77470.dtsi > +++ b/arch/arm/boot/dts/r8a77470.dtsi > @@ -196,6 +196,16 @@ > reg = <0 0xe6160000 0 0x100>; > }; > > + rwdt: watchdog@e6020000 { Please follow the sort order rules: - By unit-address (if present), per group, - Alphabetically. > + compatible = "renesas,r8a77470-wdt", > + "renesas,rcar-gen2-wdt"; > + reg = <0 0xe6020000 0 0x0c>; > + clocks = <&cpg CPG_MOD 402>; > + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; > + resets = <&cpg 402>; > + status = "disabled"; > + }; > + > sysc: system-controller@e6180000 { > compatible = "renesas,r8a77470-sysc"; > reg = <0 0xe6180000 0 0x200>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds