Hi Kieran, On Fri, Nov 02, 2018 at 01:29:54PM +0000, Kieran Bingham wrote: ... > >>>> +Required endpoint nodes: > >>>> +----------------------- > >>>> + > >>>> +The connections to the MAX9286 GMSL and its endpoint nodes are modeled using > >>>> +the OF graph bindings in accordance with the video interface bindings defined > >>>> +in Documentation/devicetree/bindings/media/video-interfaces.txt. > >>>> + > >>>> +The following table lists the port number corresponding to each device port. > >>>> + > >>>> + Port Description > >>>> + ---------------------------------------- > >>>> + Port 0 GMSL Input 0 > >>>> + Port 1 GMSL Input 1 > >>>> + Port 2 GMSL Input 2 > >>>> + Port 3 GMSL Input 3 > >>>> + Port 4 CSI-2 Output > >>>> + > >>>> +Optional Endpoint Properties for GSML Input Ports (Port [0-3]): > > > > I guess Sakari means s/3/4 here: ^ > > > > That would be incorrect, because Port 4 is an output port, not an input > port. > > > Or didn't I get his questions and then neither your answer :) ? > > > > Thanks > > j > > > >>> > >>> Isn't port 4 included? > >> > >> Hrm ... yes well I guess these are mandatory for port 4. I'll look at > >> the wording here. > > Port 4 does also need a remote-endpoint, but it is to a CSI2 sink > endpoint node. Not a GMSL source endpoint node - hence it's not > appropriate to just 's/3/4/' above. Ah, right. And now I recall Rob's position has been that remote-endpoint property doesn't really need documenting in per-device bindings as it's part of the graph bindings anyway; just refer to the graph bindings --- just like you refer to video-interfaces.txt. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx
