On Tue, Oct 30, 2018 at 04:48:30PM +0000, Biju Das wrote:
> Hi Simon,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
> >
> > On Fri, Oct 26, 2018 at 09:48:29AM +0100, Biju Das wrote:
> > > This patch enables cmt0 support on the iWave iwg23s sbc.
> > >
> > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> >
> > Thanks, I applied this for v4.21, resolving a conflict.
> > The result is as follows:
> >
> > From: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Date: Fri, 26 Oct 2018 09:48:29 +0100
> > Subject: [PATCH] ARM: dts: iwg23s-sbc: Enable cmt0
> >
> > This patch enables cmt0 support on the iWave iwg23s sbc.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > index ffd8216f28c3..295f11afac21 100644
> > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > @@ -77,6 +77,10 @@
> > clock-frequency = <20000000>;
> > };
> >
> > +&cmt0 {
> > +status = "okay";
> > +};
>
> I believe as per our process, the nodes should be in alphabetical order,
> If it is the case, it should be above extal_clk
>
> &extal_clk {
> clock-frequency = <20000000>;
> };
>
> > &pfc {
> > mmc_pins_uhs: mmc_uhs {
> > groups = "mmc_data8", "mmc_ctrl";
Yes, indeed. That was my intention but I messed things up.
I've updated the patch accordingly.
From: Biju Das <biju.das@xxxxxxxxxxxxxx>
Date: Fri, 26 Oct 2018 09:48:29 +0100
Subject: [PATCH] ARM: dts: iwg23s-sbc: Enable cmt0
This patch enables cmt0 support on the iWave iwg23s sbc.
Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
---
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index ffd8216f28c3..18d22631e188 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -73,6 +73,10 @@
};
};
+&cmt0 {
+ status = "okay";
+};
+
&extal_clk {
clock-frequency = <20000000>;
};
--
2.11.0
