Dear Sergei Shtylyov-san
On 2018/10/22 17:21, Sergei Shtylyov wrote:
Hello!
On 22.10.2018 9:30, Nguyen An Hoan wrote:
From: Hoan Nguyen An <na-hoan@xxxxxxxxxxx>
From previous commit 0521ccb "drm: rcar-du: Cache DSYSR value to
ensure known initial value"
When you cite an commit, at least 12 digits of SHA1 are needed, and
the summary needs to enclosed in (""), no just "".
We only need to update DSYSR0, DSYSR2 for start/stop. So using rgrp->
mmio_offset is enough,
the change back from rcar_du_crtc -> rcar_du_group -> rcar_du_crtc
leading to
mmio addresses for DSYSR may be different.
Signed-off-by: Hoan Nguyen An <na-hoan@xxxxxxxxxxx>
---
drivers/gpu/drm/rcar-du/rcar_du_group.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_group.c
b/drivers/gpu/drm/rcar-du/rcar_du_group.c
index d85f0a1..a5f7eed 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_group.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_group.c
@@ -202,10 +202,9 @@ void rcar_du_group_put(struct rcar_du_group *rgrp)
static void __rcar_du_group_start_stop(struct rcar_du_group *rgrp,
bool start)
{
- struct rcar_du_crtc *rcrtc = &rgrp->dev->crtcs[rgrp->index * 2];
-
- rcar_du_crtc_dsysr_clr_set(rcrtc, DSYSR_DRES | DSYSR_DEN,
- start ? DSYSR_DEN : DSYSR_DRES);
The continuation line indentation style used above is different
from yours below.
would be preferable to keep the existing style...
Thank you for the comments, and the notes to me about code rules.
I note and improve for the next time, thank you!
Hoan.
+ rcar_du_group_write(rgrp, DSYSR,
+ (rcar_du_group_read(rgrp, DSYSR) & ~(DSYSR_DRES |
DSYSR_DEN)) |
+ (start ? DSYSR_DEN : DSYSR_DRES));
}
void rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool start)
MBR, Sergei
