Hi Laurent,
Thank you for the patch,
On 17/10/18 20:20, Laurent Pinchart wrote:
> The drm_vblank_init() takes the total number of CRTCs as an argument,
> but the rcar-du driver passes a bitmask of the CRTC indices. Fix it.
>
That seems like an oops! But I guess it's not particularly fatal - just
some wasted memory perhaps.
> Fixes: 4bf8e1962f91 ("drm: Renesas R-Car Display Unit DRM driver")
> Reported-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index 4ebd61ecbee1..fe6f65c94eef 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -582,7 +582,7 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu)
> * Initialize vertical blanking interrupts handling. Start with vblank
> * disabled for all CRTCs.
> */
> - ret = drm_vblank_init(dev, (1 << rcdu->num_crtcs) - 1);
> + ret = drm_vblank_init(dev, rcdu->num_crtcs);
> if (ret < 0)
> return ret;
>
>
