RE: [PATCH] arm64: dts: renesas: add/enable USB2.0 peripheral for R-Car [DE]3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju-san,

> From: Biju Das, Sent: Friday, October 12, 2018 5:32 PM
> 
> Hi Shimoda-San,
> 
> Thanks for the patch.
> 
> > -----Original Message-----
> > From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx <linux-renesas-soc-
> > owner@xxxxxxxxxxxxxxx> On Behalf Of Yoshihiro Shimoda
> > Sent: 09 October 2018 11:45
<snip>
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > index 7278cd5..e3726307 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > @@ -357,6 +357,51 @@
> >  			resets = <&cpg 407>;
> >  		};
> >
> > +		hsusb: usb@e6590000 {
> > +			compatible = "renesas,usbhs-r8a77990",
> > +				     "renesas,rcar-gen3-usbhs";
> > +			reg = <0 0xe6590000 0 0x100>;
> 
> is it not 0x200?
> 
> Renesas_usbhs driver("drivers/usb/renesas_usbhs/common.c ")  maps the address up to 0x100 using "devm_ioremap_resource"
> function
> 
> where as the  "drivers/usb/renesas_usbhs/rcar3"  access  addresses beyond 0x100 (for eg:- 0x102,0x180,0x184,0x188) using
> iowrite32/16 calls.
> 
> This issue is present in other R-Car Gen3 variant as well(for eg:- R-Car H3/M3-W,..... etc).

Thank you very much for your report!
You're collect. So, I'll submit a patch to resolve it for all R-Car Gen3 SoCs.

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux