On 10/08/2018 11:12 AM, Geert Uytterhoeven wrote:
>> Describe THS/CIVM in the R8A77970 device trees.
>>
>> Based on the original (and large) patches by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>>
>> ---
>> This patch is against the 'renesas-devel-20181004-v4.19-rc6' tag of Simon
>> Horman's 'renesas.git' repo.
>>
>> The thermal driver/bindings patches have been posted yesterday...
>>
>> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 32 ++++++++++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
>> @@ -300,6 +300,19 @@
>> #power-domain-cells = <1>;
>> };
>>
>> + thermal: thermal@e6190000 {
>> + compatible = "renesas,thermal-r8a77970";
>> + reg = <0 0xe6190000 0 0x14
>
> 0x14 was appropriate for R-Mobile APE6...
Copy&paste is to blame here, I guess... I'll fix to 0x10.
>
>> + 0 0xe6190100 0 0x38>;
>
> What about the CIVM status register? DT describes hardware, not driver
> limitations.
I wasn't sure whether to put it into a separate "reg" tuple (which would confuse
the driver) or not. After looking into the manual again, I'm going to extend the
2nd "reg" tuple...
>> + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 522>;
>> + power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
>> + resets = <&cpg 522>;
>> + #thermal-sensor-cells = <0>;
>> + };
>> +
>> intc_ex: interrupt-controller@e61c0000 {
>> compatible = "renesas,intc-ex-r8a77970", "renesas,irqc";
>> #interrupt-cells = <2>;
>
> The rest looks good to me, so with the above fixed:
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thanks :-)
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
