Re: [PATCH] thermal: rcar_thermal: fix duplicate IRQ request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



CC Kaneko-san,

On Wed, Oct 3, 2018 at 10:47 PM Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> The driver on R8A77995 requests the same IRQ twice since
> platform_get_resource() is always called for the 1st IRQ resource.
>
> Fixes: 1969d9dc2079 ("thermal: rcar_thermal: add r8a77995 support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

Nice catch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- linux.orig/drivers/thermal/rcar_thermal.c
> +++ linux/drivers/thermal/rcar_thermal.c
> @@ -504,7 +504,7 @@ static int rcar_thermal_probe(struct pla
>         pm_runtime_get_sync(dev);
>
>         for (i = 0; i < chip->nirqs; i++) {
> -               irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> +               irq = platform_get_resource(pdev, IORESOURCE_IRQ, i);
>                 if (!irq)
>                         continue;
>                 if (!common->base) {


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux