On Wed, Sep 26, 2018 at 05:00:26PM +0200, Niklas Söderlund wrote: > From: Masaharu Hayakawa <masaharu.hayakawa.ry@xxxxxxxxxxx> > > The initial value of the interrupt mask register may be different from > the H/W manual at the startup of the kernel by setting from the > bootloader. Since the error interrupts may be unmasked, the driver sets > initial value. > > The initial value is only known for R-Car Gen2 and Gen3 platforms so > limit the initialization to those platforms. > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@xxxxxxxxxxx> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > --- > > * Changes since v1 > - Limit the initialization to Gen2+ platforms by checking the > TMIO_MMC_MIN_RCAR2 flag. > - Rename the constant for the initialization value to reflect it's only > for R-Car Gen2+ platforms. Those changes are good! I wonder, though, if we shouldn't move the code out of TMIO core into the SDHI core? This seems very Renesas specific. What do you think?
Attachment:
signature.asc
Description: PGP signature
