On Fri, Sep 21, 2018 at 07:14:02PM +0300, Sergei Shtylyov wrote: > On 09/19/2018 11:06 AM, Simon Horman wrote: > > > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@xxxxxxxxxxx> > > > > This patch sets from two descriptor to one descriptor because R-Car Gen3 > > does not have the 4 bytes alignment restriction of the transmission buffer. > > > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@xxxxxxxxxxx> > > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > --- > > v2 [Simon Horman] > > * As per review by Sergi Shtylyov > > It's Sergei or (more correctly) Sergey. :-) Sorry, that was completely unintentional. > > > - Use reverse xmas tree for variable declarations > > - Use > rather than >= for conditions > > - Dropped unnecessary parentheses > > - Don't allocate memory for tx_align when it will not be used > > - But, kept NUM_TX_DESC_GEN[23] as I see some value in > > the self-documentation provided by these #defines > [...] > > Better late than never (-: > > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > MBR, Sergei >
