Hi Simon-san, > From: Simon Horman, Sent: Friday, September 21, 2018 4:37 PM > > On Thu, Sep 20, 2018 at 05:55:00AM +0000, Yoshihiro Shimoda wrote: > > Hi Simon-san, > > > > > From: Simon Horman, Sent: Wednesday, September 5, 2018 7:33 PM > > > > > > On Fri, Aug 31, 2018 at 05:20:51PM +0900, Yoshihiro Shimoda wrote: > > > > R-Car Gen3 needs to enable/deassert clocks/resets of both usb 2.0 > > > > host (included phy) and peripheral. Otherwise, other side device > > > > cannot work correctly. So, this patch revises properties of clocks > > > > and resets. After that, each device driver can enable/deassert > > > > clocks/resets by its self. > > > > > > > > Notes: > > > > - To work the renesas_usbhs driver correctly when host side drivers > > > > are disabled and the renesas_usbhs driver doesn't have multiple > > > > clock management, this patch doesn't change the order of the clocks > > > > property in each hsusb node. > > > > - This patch doesn't have any side-effects even if the renesas_usbhs > > > > driver doesn't have reset_control and multiple clock management. > > > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > > > > > Thanks Shimoda-san, > > > > > > This looks fine to me but I will wait to see if there are other reviews > > > before applying. > > > > > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > > > Thank you for your review! > > However, since clock-names will be not used by renesas_usbhs driver, > > I'll submit v2 patch to remove the properties. > > Thanks, I'll wait for v2. I submitted v2 patch: https://patchwork.kernel.org/patch/10609245/ Best regards, Yoshihiro Shimoda
